Keep the system_prompt as an attribute of the agent. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 54.86% 54.89% +0.03%
==========================================
Files 11 11
Lines 1489 1490 +1
==========================================
+ Hits 817 818 +1
Misses 672 672
🚀 New features to boost your workflow:
|
|
fixed the whitespace issue |
|
Don't output Persona metadata in the prompt() |
| @@ -486,6 +488,8 @@ def __init__(self, | |||
| stop_word=self.STOP_WORD | |||
| ) | |||
|
|
|||
| self.system_prompt = system_prompt | |||
There was a problem hiding this comment.
Does it make sense to have the self.system_prompt as an attribute that is never used inside the class? the self.prompt() will return exactly the same as self.system_prompt.
There was a problem hiding this comment.
Indeed, if self.prompt() returns exactly that, there is no point in adding it as an attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.